Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CustomField): add a way to have icon in custom fields #1780

Merged
merged 3 commits into from May 20, 2024

Conversation

dhavalsavalia
Copy link
Contributor

addresses #1743

It is using Phosphor Icons at the moment but I am thinking Simple Icons are essential for branded icons.

Here is how it looks:
CleanShot 2024-02-18 at 13 15 23@2x

CleanShot 2024-02-18 at 13 15 42@2x

CleanShot 2024-02-18 at 13 14 39@2x

@dhavalsavalia
Copy link
Contributor Author

2dce782 introduces a change in the Profiles section of the templates. Now, if an icon is set for a profile, the network name will not be displayed to reduce redundancy. This makes the UI cleaner and more intuitive, as the icon already represents the network.

@AmruthPillai
Copy link
Owner

This is really useful, thank you for the PR. Will get this merged ASAP!

@AmruthPillai AmruthPillai merged commit 0124db0 into AmruthPillai:main May 20, 2024
1 check failed
Copy link

nx-cloud bot commented May 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a033c3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many -t lint

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants