Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of rotate_pairs #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update of rotate_pairs #70

wants to merge 2 commits into from

Commits on Oct 6, 2020

  1. Update rotate_pairs.py 

    The current solution does not check for all rotated words, due to the stop argument of the range being 14 instead of 26 in the rotate_pairs function. For example, the word "act" should print out "act 24 yar", but currently does not print out anything.

As the current solution uses a somewhat brute force approach, my suggested solution uses a different approach, where each word is rotated only once. It also makes use of a dictionary to store the rotate pairs, by using the setdefault method covered in Exercise 11.2.

This suggested solution also directly addresses the specification of the exercise description ("Write a program that reads a wordlist and finds all the rotate pairs."). Only the word_list needs to be provided as argument, and a list containing lists with all rotate pairs is returned. Each word is thus contained only once in the returned list of lists.

Since the suggested approach does not need to check for the presence of a word in the list of words, the words can be provided simply as a list instead of a dict.
    @DavidVFitzGerald
    DavidVFitzGerald committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    a88192a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from DavidVFitzGerald/rotate_pairs 

    Update rotate_pairs.py
    @DavidVFitzGerald
    DavidVFitzGerald committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    f04a095 View commit details
    Browse the repository at this point in the history