Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set deviceCategory exposed in homekit while proxying #985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Minims
Copy link

@Minims Minims commented Mar 5, 2024

Hello,

I have open this FR #982 and trying to add it now.

I don't really know what change are need, but as i understand, this PR can be the beginning of the feature.

Waiting for your feedback @AlexxIT

Thanks.

@AlexxIT
Copy link
Owner

AlexxIT commented Mar 6, 2024

Are you sure this is enough? HomeKit has a rules for devices. Doorbell should have a button, maybe something else.

@Minims
Copy link
Author

Minims commented Mar 6, 2024

I’m not sure and i don’t know how to test my code change.

I would expect that proxying expose all original devices and not only camera.

Maybe it’s possible to do that in go2rtc for every homekit devices ?

@AlexxIT
Copy link
Owner

AlexxIT commented Mar 6, 2024

Oh. This make sense for proxy mode.

@Minims
Copy link
Author

Minims commented Mar 19, 2024

It seems the current CategoryCamera does not proxy only the camera.

I have a "Somfy Indoor Camera" and the 4th entity are available (and working) in both Homekit and HA.

  • Stream
  • Identify
  • Mute Camera
  • Motion Sensor

So I would say it will also work for DoorBell or Bridge Category.

@AlexxIT
Copy link
Owner

AlexxIT commented Apr 22, 2024

Your code will not compile anyway.

@AlexxIT AlexxIT added the doubt label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants