Feat: Expressions anywhere in the configuration #930
+174
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the ability to preprocess configuration data to evaluate expressions contained within it before the data is unmarshalled into Go structures. It leverages a new function, `ProcessConfig`, from the `expr` package, which searches for and evaluates expressions denoted by `${{...}}` syntax.
Additionally, this commit includes comprehensive tests for both the `LoadConfig` function and the newly added `processConfig` logic to ensure that expressions are correctly evaluated and that the configuration loading behaves as expected, even when faced with invalid configurations or expressions.
The ability to preprocess and evaluate expressions within the configuration could simplify dynamic configuration scenarios and reduce the need for external templating tools.
|
Just wondering, why not add support for go-template the config file directly? |
What do you mean? Go-template is a template engine, but my idea is in a dynamic calculated configuration file |
|
If you make the config file a template, and use go-template to render it before consuming from it, it should give a similar result but maybe more powerful. streams:
test:
- rtps://{{ env "MY_USER" }}:{{ env "MY_PASS" }}@myhost.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to preprocess configuration data to evaluate expressions contained within it.
The ability to preprocess and evaluate expressions within the configuration could simplify dynamic configuration scenarios and reduce the need for external templating tools.
example:
will be pre-processed to
http://192.168.88.158/live/index.m3u8Roadmap: