Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pure-go ngrok tunneling in the API #528

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for pure-go ngrok tunneling in the API #528

wants to merge 3 commits into from
+87 −8

Conversation

skrashevich
Copy link
Contributor

No description provided.

@felipecrs
Copy link
Contributor

Maybe you can remove ngrok from the Dockerfile now?

@AlexxIT
Copy link
Owner

AlexxIT commented Jul 24, 2023

This is wrong realisation with proxing only API port. But idea was about proxing WebRTC port.
Also I need to check go2rtc binary size change.
And including so many external dependencies for so not popular feature - not a good idea.
I need to think about this PR.

@skrashevich
Copy link
Contributor Author

skrashevich commented Jul 26, 2023 •
edited

Also I need to check go2rtc binary size change.

+2M (unpacked)

@AlexxIT AlexxIT force-pushed the master branch 4 times, most recently from 50492e5 to 279d8bf Compare August 20, 2023 20:41
@AlexxIT AlexxIT mentioned this pull request Nov 17, 2023
Merged
@AlexxIT AlexxIT added the doubt label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skrashevich @felipecrs @AlexxIT