refactor(sysctl): consolidate platform-specific syscall files #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `syscall_linux.go` to `syscall.go` with build constraints for non-BSD and non-Windows platforms. - Merge `syscall_darwin.go` into `syscall_bsd.go` and adjust build constraints for BSD platforms (Darwin, FreeBSD, OpenBSD). - Remove redundant `syscall_freebsd.go`. - Add build constraints to `syscall_windows.go` for Windows platform.
|
It won't help. FFmpeg is also bound to the OS |
- Rename `device_freebsd.go` to `device_bsd.go` and `hardware_freebsd.go` to `hardware_bsd.go` to reflect broader BSD support (FreeBSD, NetBSD, OpenBSD, Dragonfly). - Update build tags in `device_bsd.go` and `hardware_bsd.go` to include FreeBSD, NetBSD, OpenBSD, and Dragonfly. - Rename `device_linux.go` to `device_unix.go` and `hardware_linux.go` to `hardware_unix.go` to generalize Unix support excluding Darwin-based systems and BSDs. - Add specific build tags to `device_darwin.go`, `device_unix.go`, `hardware_darwin.go`, and `hardware_unix.go` to correctly target their respective operating systems. - Ensure Windows-specific files (`device_windows.go` and `hardware_windows.go`) are correctly tagged for building on Windows.
skrashevich
changed the title
fixed |
AlexxIT
approved these changes
May 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syscall_linux.gotosyscall.gowith build constraints for non-BSD and non-Windows platforms.syscall_darwin.gointosyscall_bsd.goand adjust build constraints for BSD platforms (Darwin, FreeBSD, OpenBSD).syscall_freebsd.go.syscall_windows.gofor Windows platform.device_freebsd.gotodevice_bsd.goandhardware_freebsd.gotohardware_bsd.goto reflect broader BSD support (FreeBSD, NetBSD, OpenBSD, Dragonfly).device_bsd.goandhardware_bsd.goto include FreeBSD, NetBSD, OpenBSD, and Dragonfly.device_linux.gotodevice_unix.goandhardware_linux.gotohardware_unix.goto generalize Unix support excluding Darwin-based systems and BSDs.device_darwin.go,device_unix.go,hardware_darwin.go, andhardware_unix.goto correctly target their respective operating systems.device_windows.goandhardware_windows.go) are correctly tagged for building on Windows.The main point of the changes: the ability to build a project for any POSIX-compatible system, not limited to a {linux,darwin,windows,freebsd} list