feat(docker): update Dockerfiles to use ENTRYPOINT instead of CMD #1016
+22
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cross-platform compatibility - Updated Dockerfile and hardware.Dockerfile syntax to `docker/dockerfile:1.4` for enhanced features and performance. - Introduced `--link` option in COPY commands to optimize layer caching and reduce image size. - Added a new `entrypoint.sh` script for dynamic configuration and validation of environment variables, improving container startup flexibility. - Included `yq` utility in the base images to facilitate YAML file manipulation within the container, enhancing configuration management capabilities. - Specified `--platform=linux/amd64` for base images to ensure consistent cross-platform builds, addressing potential compatibility issues on multi-architecture setups. - Modified ENTRYPOINT to utilize the new entrypoint script, enabling pre-execution configuration checks and setting a default configuration if none is provided. - The addition of `yq` and changes to the entrypoint mechanism provide a more robust and user-friendly setup process, potentially affecting existing workflows that rely on manual configuration file adjustments. These changes aim to improve maintainability, efficiency, and user experience by leveraging newer Docker features, automating configuration tasks, and ensuring broader compatibility across different computing environments.
|
Why we need to create config file? User can set default port just via command line |
|
because of without config file: Also, listening to the port given by the |
|
Config file is not set - error only when user set config as string. It's planned behaviour. |
anyway, other reasons still significant:
|
Both this instruments can be used to set port |
This all requires a separate configuration from user, not a default behavior for go2rtc container |
|
No. 2nd can be used in raw docker compose file. Without any file config |
- Removed `yq` installation from Dockerfile to reduce image size. - Simplified default configuration file creation in entrypoint.sh by directly writing YAML content, eliminating the need for `yq`. - Removed `yq` installation step from hardware.Dockerfile and adjusted file copying accordingly.
Simplify the entrypoint script by removing the creation of a default configuration file if it doesn't exist. Instead, directly pass the default API listen port configuration to the `go2rtc` command, while still allowing custom configurations through the existing `CONFIG_PATH`. This change ensures that the service can start with default settings without needing to write them to a file, simplifying deployment and configuration management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entrypoint.shscript for dynamic configuration and validation of environment variables, improving container startup flexibility.yqutility in the base images to facilitate YAML file manipulation within the container, enhancing configuration management capabilities.--platform=linux/amd64for base images to ensure consistent cross-platform builds, addressing potential compatibility issues on multi-architecture setups.