Refactor proof state #1875
Open
Refactor proof state #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
vicsn
force-pushed
the
lineval
branch
3 times, most recently
from
9f88bc2
to
b7a2383
Compare
vicsn
force-pushed
the
refactor_proof_state
branch
from
55a03e9
to
a7fcced
Compare
vicsn
force-pushed
the
refactor_proof_state
branch
from
a7fcced
to
f3bca12
Compare
Pratyush
reviewed
Sep 6, 2023
algorithms/src/snark/varuna/ahp/prover/round_functions/second.rs
Outdated
Show resolved
Hide resolved
Pratyush
reviewed
Sep 6, 2023
Pratyush
reviewed
Sep 6, 2023
Pratyush
reviewed
Sep 6, 2023
vicsn
force-pushed
the
reduce_pk_size_2
branch
3 times, most recently
from
3b3ae6f
to
e3976b0
Compare
vicsn
force-pushed
the
refactor_proof_state
branch
from
c894c4b
to
6e6824e
Compare
Pratyush
approved these changes
Sep 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The round functions mutate prover/verifier state and keep passing it as they go along, see as a starting point
algorithms/src/snark/varuna/varuna.rs
This PR cleans that up by making round functions members of prover/verifier
State. We also make verifier State a member of prover State.Test Plan
This is just a refactor which should not impact any values or tests.