[Fix] Guard recursive certificate fetching with is_synced check.
#3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
approved these changes
May 16, 2024
howardwu
approved these changes
May 23, 2024
vicsn
added a commit
to ProvableHQ/snarkOS
that referenced
this pull request
May 28, 2024
…yncing-check"" This reverts commit 223a1b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR prevents nodes from recursively fetching missing certificates, despite syncing via blocks. This should not happen, and the node should focus on syncing via the blocks.
We noticed this edge case where a node would be considered synced for a moment and then start fetching certificates from peers. This cycle can go on for a long time since there may be many certificates to request, however this should be cut short when the node realizes that it should be syncing via blocks instead.