Add experimental SOCKS5 support for S3 #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
force-pushed
the
ivanyu/socks5-aws
branch
4 times, most recently
from
352d559
to
87fdbde
Compare
Technically, I found a way to have proxy-side host name resolution, but it requires rewriting quite a bit of the AWS client machinery. Leaving it as is for now.
ivanyu
force-pushed
the
ivanyu/socks5-aws
branch
from
87fdbde
to
87b89b1
Compare
|
@jeqo I isolated all the reflection operations in a separate package + added a comment on this. Even when this becomes non-experimental, most likely the reflection magic stays: the AWS SDK isn't just configurable enough to do what we want as we did with the other clouds. |
Isolate the proxy installation and related reflection operations
ivanyu
force-pushed
the
ivanyu/socks5-aws
branch
from
89eb9a2
to
dd35e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, I found a way to have proxy-side host name resolution, but it requires rewriting quite a bit of the AWS client machinery. Leaving it as is for now.