replace dateutil with fromisoformat in google backend #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dateutil.parser.parse is particularly slow and covers a lot of use cases that are not relevant to parsing RFC 3339 datetimes. This was bad enough that rohmu could eat 50% of CPU while listing entries from Google object storage.
kmichel-aiven
force-pushed
the
kmichel-fast-date
branch
from
141f9f4
to
d33b77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
replace dateutil with fromisoformat in google backend.
Why this way
dateutil.parser.parseis particularly slow and covers a lot of use cases that are not relevant to parsing RFC 3339 datetimes.This was bad enough that rohmu could eat >50% of CPU while listing entries from Google object storage.
(The next high CPU user is
json.decode, but that's still far behinddateutiland harder to fix since it's insidegoogleapiclient.)