pghoard: ignore delta backup failures counter in some cases #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cases: 1. Backup was requested by operator: `AVN-PROD service request-backup` 2. More than `backup_interval` have passed since the last unsuccessful attempt [BF-2390]
egor-voynov-aiven
changed the title
On CI environment threads don't have enough time for initialization.
0xlianhu
reviewed
May 2, 2024
| since_last_fail_interval = utc_now() - last_failed_time if last_failed_time else None | ||
| if metadata["backup-reason"] == BackupReason.requested: | ||
| self.log.info("Re-trying delta basebackup. Backup was requested") | ||
| elif backup_interval and since_last_fail_interval and since_last_fail_interval > backup_interval: |
There was a problem hiding this comment.
Need to discuss whether we need to consider backoff retry internal for this two new cases. Just keeping retrying without waiting a bit seems less meaningful to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pghoard will try making backup in this cases, еven if the retries are over:
backup_intervalhave passed since the last unsuccessful attempt[BF-2390]
Pghoard can stuck in state, when it doesn't make backup after several failures. It just writes in log
Giving up backup after exceeding max retriesand only restart can help.