Update workflow to be used in merge queue. #2420
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmiri
force-pushed
the
add-merge-queue
branch
from
3011f21
to
5cd313e
Compare
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
programmiri
force-pushed
the
add-merge-queue
branch
from
5cd313e
to
6e0b0b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2419
Note:
This is more complicated as expected unfortunately, as having a workflow that runs only in the queue is not straightforward.
Currently, what I read up and tested, this is how it should work:
-> workflow is triggered on PR event AND merge_group event
-> jobs only should run when it's really queued (not for e.g. opening a PR)
-> job still needs to be triggered by required checks AND required merge groups
This does not seem to work as expected, though, because while the last test run only merged after the required jobs where done, it seems like on the test-main branch another job failed later. This could have been due to timing though and needs more investigation.
Will keep this Draft open for now, but it's not merge ready yet.