fix: harden the order of keys that needs to be serialized #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
force-pushed
the
eliax1996/ensure-canonical-format-of-keys-is-stable
branch
2 times, most recently
from
ef899bd
to
c313d24
Compare
eliax1996
force-pushed
the
eliax1996/ensure-canonical-format-of-keys-is-stable
branch
from
c313d24
to
2f19386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this way
Previously we were relying on the fact that the
.keys()order and thejson.dumps()order are always sync. This enforces by theOrderedDicta fixed order. Not sure if the same odering check should be performed also for theis_key_in_canonical_format, probably here we want to ensure that the current dict has exactly the same order in thekeys().