fix: Clarify comment in backup consumer logic #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
reviewed
Dec 14, 2023
Comment on lines
+303
to
+306
| # produced we need to subtract 1. Note that this has little to do with high | ||
| # watermark, which takes into account the highest record offset to be fully | ||
| # in sync across ISRs, and therefore can be an arbitrary number less than | ||
| # or equal to the LEO. |
There was a problem hiding this comment.
great, thanks for the explaination! This save a lot of time to the reader of the code. Can we mention also what happens if the topic its empty?
matyaskuti
reviewed
Dec 15, 2023
| @@ -298,7 +298,13 @@ def _consume_records( | |||
| if start_offset >= end_offset: | |||
| raise EmptyPartition | |||
|
|
|||
| end_offset -= 1 # high watermark to actual end offset | |||
| # kafka-python returns end offset + 1, i.e. the value that will be assigned | |||
There was a problem hiding this comment.
kafka-python -> confluent-kafka-python now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.