Improve error message in case of a Kafka timeout #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case that can be seen in the stacktrace below, the customer gets 500 internal error.
Add handling of KafkaTimeoutException and return HTTP 504 in that case.
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/karapace/rapu.py", line 323, in _handle_request
data = await callback(**callback_kwargs)
File "/usr/lib/python3.10/site-packages/karapace/schema_registry_apis.py", line 491, in config_set
self.schema_registry.send_config_message(compatibility_level=compatibility_level, subject=None)
File "/usr/lib/python3.10/site-packages/karapace/schema_registry.py", line 483, in send_config_message
return self.send_kafka_message(key, value)
File "/usr/lib/python3.10/site-packages/karapace/schema_registry.py", line 408, in send_kafka_message
future = self.producer.send(
File "/usr/lib/python3.10/site-packages/kafka/producer/kafka.py", line 581, in send
self._wait_on_metadata(topic, self.config['max_block_ms'] / 1000.0)
File "/usr/lib/python3.10/site-packages/kafka/producer/kafka.py", line 707, in _wait_on_metadata
raise Errors.KafkaTimeoutError(
kafka.errors.KafkaTimeoutError: KafkaTimeoutError: Failed to update metadata after 2.0 secs.
juha-aiven
force-pushed
the
juham-improve-error-code-on-kafka-timeout
branch
from
8bc360e
to
222b239
Compare
jjaakola-aiven
requested changes
Nov 22, 2022
| @@ -52,6 +53,7 @@ class SchemaErrorCodes(Enum): | |||
| INVALID_SUBJECT = 42208 | |||
| SCHEMA_TOO_LARGE_ERROR_CODE = 42209 | |||
| NO_MASTER_ERROR = 50003 | |||
| KAFKA_TIMEOUT_ERROR_CODE = 50004 | |||
There was a problem hiding this comment.
Better error code would be 50002 which is OPERATION_TIMEOUT_ERROR_CODE in CSR.
50004 is reserved for unknown leader error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that can be seen in the stacktrace below, the customer gets 500 internal error.
Add handling of KafkaTimeoutException and return HTTP 504 in that case.