Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loading indicator #182 #255

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Arskan17
Copy link
Contributor

@Arskan17 Arskan17 commented Feb 6, 2024

So.. I tried to do it as suggested in the issue's description, but I don't know how to move forward...

  • I added the loading attribute in app/ui/omni-box.js, and emit the events from app/window.js, which I then listen for in app/ui/script.js. This then changes the attribute's value to either true or false depending on the event.
  • I added a random spinning indicator in app/ui/style.css named .spinner.
  • It's a separate button with its own div id. You can see it in the image attached

loader

The issue is;

  • I don't know if I'm handling the attributeChangedCallback correctly. I added this.loader = this.$('omni-box-button') and use this.loader.getElementById().classList.toggle() to either make the buttons hidden or visible, but they both stay constantly visible...
  • I change the value of loading directly in app/ui/script.js when listening for the event, but I'm not sure whether that's even correct, or I should handle it some other way?

Any suggestions on how to move from here ?

Not quite done.
still need to display the css loading circle
The spinner is shown, but is there indefinitely.
It doesn't go away, even when the page stops loading
@Arskan17
Copy link
Contributor Author

Arskan17 commented Feb 6, 2024

Hey @RangerMauve... mind taking a look?
Thanks a lot!

@Arskan17 Arskan17 closed this Feb 8, 2024
@Arskan17 Arskan17 deleted the Loading-indicator-#182 branch February 8, 2024 16:39
@Arskan17 Arskan17 restored the Loading-indicator-#182 branch February 8, 2024 20:47
@Arskan17 Arskan17 reopened this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant