Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validationStatus of FormAddressPickerItem #1679

Merged
merged 3 commits into from
May 16, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented May 15, 2024

Summary

  • Returning nil on validationStatus() to prevent an assertion in debug mode when using a FormPickerItem or FormAddressPickerItem

Also

  • Fixes configuration of the AdyenTwint target for the AdyenUIHost to not embed the TwintSDK.framework

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

nauaros
nauaros previously approved these changes May 15, 2024
@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label May 15, 2024
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
@goergisn goergisn dismissed stale reviews from github-actions and nauaros via 740fe8d May 16, 2024 05:51
github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
@goergisn goergisn requested a review from nauaros May 16, 2024 05:54
Copy link

sonarcloud bot commented May 16, 2024

@nauaros nauaros merged commit b6808c4 into develop May 16, 2024
11 of 12 checks passed
@nauaros nauaros deleted the fix_picker_item_validation_status branch May 16, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants