-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegated authentication feature changes #1549
Draft
robertdalmeida
wants to merge
106
commits into
develop
Choose a base branch
from
delegated-authentication-intermediate-screens-base
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Delegated authentication feature changes #1549
robertdalmeida
wants to merge
106
commits into
develop
from
delegated-authentication-intermediate-screens-base
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the register and approve screens.
…ted authentication
…ng of the textview
…tisfy the pipeline
…mediate-DA-feature-delete-api-
…mediate-da-feature/revisit-public-interface
…1546) As per our discussions during the code review we wanted to update the public interface of the ThreeDSComponent.
1 task
goergisn
approved these changes
Mar 19, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support screens to register and approve in the delegated authentication flow.
Additionally updated to the feature branch:
Delegated authentication intermediate screens
Tested scenarios
Register for DA
Register.mov
Approval using DA
ApproveCredentials.mov
Delete credentials
DeleteCredentials.mov
Timeout
TimeoutDuringApproval.mov