Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark get_access for target::host_buffer as deprecated #979

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dnhsieh-intel
Copy link

This PR fixes Issue #973.

@illuhad
Copy link
Collaborator

illuhad commented Mar 20, 2023

Thanks! It seems we use this function still in a couple of places in our tests - CI is now full of warnings. Do you want to migrate those cases to get_host_access()? I don't want to force additional work on you for something that seemed like a trivial change :-)

@dnhsieh-intel
Copy link
Author

Although usually I don't like to start something and not complete it, I need to give up this time due to my recent schedule. Please take it from here. Thanks!

@illuhad
Copy link
Collaborator

illuhad commented Mar 21, 2023

No worries, I understand :-) Contributing to open source projects is not always easy to combine with other obligations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate get_access for target::host_buffer
2 participants