rewrite of group algorithms #966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DieGoldeneEnte
force-pushed
the
redo/group_algorithms
branch
3 times, most recently
from
8ccba3e
to
d642301
Compare
This implements has_known_identity and known_identity as well as tests. It also adds plus<void>, multiplies<void>, etc.
This mainly makes vec constexpr, adjusts known_identity to to be able to initialize vec and the tests to be able to check the vec-values.
also added scopedv2 support
DieGoldeneEnte
force-pushed
the
redo/group_algorithms
branch
from
d642301
to
94da34a
Compare
illuhad
reviewed
Apr 6, 2023
| HIPSYCL_BUILTIN | ||
| T exclusive_scan_over_group(Group g, T x, BinaryOperation binary_op) { | ||
| HIPSYCL_RETURN_DISPATCH_GROUP_ALGORITHM(__hipsycl_exclusive_scan_over_group, | ||
| g, x, binary_op); |
There was a problem hiding this comment.
Where did exclusive_scan_over_group without init go? The spec says we need to have this overload. I don't see it anymore, am I missing something?
There was a problem hiding this comment.
I put all backend independent implementations in line 253+. Those are functions for example without init, which can be implemented using the identity and version with init or where an index just needs to be linearized. The exclusive scan without init for example is in line 378.
DieGoldeneEnte
force-pushed
the
redo/group_algorithms
branch
from
f478739
to
f94b856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group algorithms were restructured and partially rewritten to make use of the known_identity.
Where possible functions are implemented using other group function variants to reduce code duplication.
This PR also implements functions for scoped parallelism V2 implemented using the ND-range variants.
The tests are also rewritten and only check functions that aren't implemented using others.