Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffer(shared_ptr<T[]>, ...) constructor and add some buffer tests cases #1451

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add buffer(shared_ptr<T[]>, ...) constructor and add some buffer tests cases #1451

wants to merge 6 commits into from

Conversation

nilsfriess
Copy link
Collaborator

This PR adds a missing constructor to the buffer class and introduces a few test cases, and makes a small change in the buffer shared_ptr constructors to handle the case when the shared_ptrs are empty.

@illuhad
Copy link
Collaborator

illuhad commented May 8, 2024

/run-benchmark

@illuhad illuhad added benchmark Attach to PRs to run the benchmark workflow and removed benchmark Attach to PRs to run the benchmark workflow labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
benchmark Attach to PRs to run the benchmark workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nilsfriess @illuhad