[stdpar] SyncElision: Ignore loads/store to stack locations if we don't have system USM #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t have system USM
illuhad
force-pushed
the
feature/sync-elision-ignore-stack-load-stores
branch
from
3b2e1d1
to
6a6aebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, loads/stores between stdpar calls prevent synchronization elision. We do have some heuristics to ignore some stores that are merely used to assemble stdpar function arguments.
However, if we know that we don't have system USM, we can be more aggressive and ignore any load/stores that reference stack memory. This PR implements this.