Add missing prefixes when checking if function is in std namespace
#1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling-compression certain classes in the `std` namespace have their own abbreviations and do not start with `St`.
illuhad
reviewed
Oct 30, 2023
Co-authored-by: Aksel Alpay <aksel.alpay@uni-heidelberg.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Itanium ABI spec certain classes in the
stdnamespace have their own abbreviations and do not start withStso the current check would not mark them asstdfunctions. However, I am not sure if these abbreviations are actually used by the LLVM Itanium mangler. I haven't looked at the source code yet but I looked at the symbols of some test applications usingnmand all mangled names ofstd::functions started with_ZSt,_ZNStor_ZNKSt(this last one is forconstmember functions and was missing previously), so maybe it is enough to just check for these three.Opening this as a draft for now until I'm sure which is the correct approach (hoping that someone who knows more about this sees this and can comment on it).