-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: add Nodes offline dialog #597
Open
bludnic
wants to merge
9
commits into
dev
Choose a base branch
from
feat/eth-node-web3-client-wrapper
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+321
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bludnic
commented
Feb 9, 2024
•
edited
edited
- Login: Show meaningful error message when trying to login where all ADM nodes are offline (previously "Incorrect passphrase")
- Nodes: Added a wrapper to handle NODE_OFFLINE errors
- Chat: Show a dialog when all ADM nodes are offline
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deployed to https://msg-adamant-pr-597.surge.sh 🚀 |
bludnic
changed the title
Added
Chat: add Nodes offline dialog
Feb 12, 2024
useClient()
wrapper to catch AllNodesOfflineError
within a Promise
bludnic
commented
Apr 6, 2024
@@ -98,8 +100,14 @@ export default defineComponent({ | |||
emit('login') | |||
}) | |||
.catch((err) => { | |||
if (isAxiosError(err)) { | |||
emit('error', 'login.invalid_passphrase') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
emit('error', 'login.invalid_passphrase') | |
emit('error', 'login.cannot_retrieve_the_public_key') |
PaulDremanovich
force-pushed
the
feat/eth-node-web3-client-wrapper
branch
from
April 6, 2024 12:11
821c20a
to
789d09a
Compare
# Conflicts: # src/locales/zh.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.