MNT-24219: local variables before calling subprocess remains after en… #4596
Conversation
|
Tried to make the fix as clear as possible. |
| Optional<? extends ExecutionEntity> first = parentExecution.getParent().getExecutions().stream() | ||
| .filter(executionEntity -> { | ||
| // scoped execution of the current subprocess should not be considered | ||
| return !executionEntity.getId().equals(parentExecution.getId()); | ||
| } ) | ||
| .findFirst(); | ||
| if( first.isPresent() ) { | ||
| new SubProcessVariableSnapshotter().setVariablesSnapshots(first.get(), executionToContinue); | ||
| } |
There was a problem hiding this comment.
This logic only works for some specific cases, but it cannot work in general: parentExecution.getParent().getExecutions() may return several executions depending on the process design and peeking the first one could return the wrong one. Also, there is no guarantee that the execution we are looking for is still in the database at this point, as it's marked to be deleted in ContinueProcessOperation.createChildExecutionForSubProcess and depending on the process design it may or may not be there. For instance, if the subprocess has a user task or any flow node marked as async, the execution will be already deleted from the database when we reach this point.
There was a problem hiding this comment.
I've improved the fetch of the execution but it fails when a UserTask is inside of the subprocess: the execution was already deleted.
Pushed modifications in order to continue the discussion
…d of subprocess
What kind of change does this PR introduce?
Description
Does this PR introduce a breaking change? (check one with "x")