Update ProcessInstanceHelper.java to fix runtime bundle executing wrong start event when start process instance by message [issue #4382] #4383
Conversation
This reverts commit 2c5eb43.
Fix Start Process Instance by Message
|
|
|
Hi @miguelruizdev , can you please review and approve workflow runs |
|
Hi @abhinay9955, we would need test coverage in order to accept the Pull Request. |
|
Sure @miguelruizdev , Thanks!! I could not find any test class for ProcessInstanceHelper.java , that's why didnt added tests. Will add if @igdianov asks fo it. I hope this is fine :) |
There was a problem hiding this comment.
@abhinay9955 I am a concerned that this is going to be a breaking change, ie in APS, that changes the behavior of using a model message ref to find and set message ref to message name by matching it to message id in case the message name is not matching message ref.
We need to consult with @VitoAlbano who added this code as part of this commit: 6ddaae9
Added code for condition when there is no message reference
|
Hi @igdianov , i have updated the code , i think this change addresses your concern , Thanks :) |
Can you add test coverage for it, please? Thanks! |
added getInitialFlowByMessage to seperate the logic of getting initial flow from start processInstance method
Added unit test
…bpmn20.xml Added resource for testing
|
Hi @igdianov , added unit tests please review . Thanks :) |
…ww.github.com/abhinay9955/Activiti into abhinay9955-4382-fixStartEventWithMessage
|
@VitoAlbano please review !! Thanks !! |
|
Hi @VitoAlbano @igdianov @miguelruizdev , i have added test cases long ago , can you please review . |
Update ProcessInstanceHelper.java to fix runtime bundle in activiti cloud executing wrong start event when start process instance by message [issue #4382]