Keep watched state 99a169a #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
Signed-off-by: Michel Albert <michel@albert.lu>
exhuma
force-pushed
the
keep-watched-state-99a169a
branch
from
d5f95a1
to
ca42759
Compare
Signed-off-by: Michel Albert <michel@albert.lu>
|
@AceFire6 any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #325 which was closed without comment and without ever being merged. I am assuming this was because the target branch got renamed from master to main and GitHub just closed it because the target branch "disappeared"
I have based this on commit 99a169a which I assume is the last release at the timepoint when this PR was created.
I was forced to do a bit more though, so here's some detail:
Issue with dependencies
quart-minifydepends onjsminwhich is no longer maintained and no longer installable. After fiddling around with it for a while I gave up and had to drop the devpendency on quart-minify to even get as far as install the dependencies let alone make the thing run. This has the effect that the generated output is no longer minified though :(Then there was an issue with markupsafe and jinja2 which forced me to limit/pin their versions. At least like this the project runs without causing any cumbersome code changes.
Issue with Python 3.10
It seems that quart is not compatible with Python 3.10. At least not in the version used in this project. So I added a VS-code dev-container to the project which runs a 3.9 environment. This has no impact whatsoever on the code. It merely provides a convenience for VS-Code developers to have a clean and reproducible environment to work in.
Dependency on Redis
The Redis dependency makes development a bit more annoying because you need a running Redis instance to start developing. I added the option to set the env-var to "None" to disable caching completely. This makes it much easier to set up a quick dev environment.
All remaning changes are related to the "keep-watched-state" feature.
If you want me to split this up in multiple PRs let me know. I could see that moving everything related to dev-environment and setup be in a separate PR. But for now, I keep it like this for housekeeping simplicity 馃槈