This repository has been archived by the owner on Dec 4, 2020. It is now read-only.
Added cartridge collection load test to travis. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "description": "This is the skeleton cartridge" | ||
| }, | ||
| "cartridge": { | ||
| "url": "https://github.com/RobertNorthard/adop-cartridge-skeleton.git", |
There was a problem hiding this comment.
Can we use cartridge, which's under Accenture namespace on Github i.e. not personal account?
There was a problem hiding this comment.
Thanks @anton-kasperovich updated to use skeleton cartridge under the Accenture namespace 👍
|
Dependency was merged already, I suppose you can continue work on this PR, right? |
Signed-off-by: Northard, Robert A <robert.a.northard@accenture.com>
RobertNorthard
commented
May 31, 2017
| @@ -24,10 +24,11 @@ script: | |||
| - sleep 30 | |||
| - ./adop workspace -w Travis create | |||
| - ./adop project -p TestProject -w Travis create | |||
| - ./adop project -p TestProject -w Travis load_collection -c https://raw.githubusercontent.com/Accenture/adop-docker-compose/master/test/resources/cartridge_collection.json | |||
There was a problem hiding this comment.
@anton-kasperovich I think I'll need to split this PR into two, unless I reference another cartridge collection (e.g. DOA) but I don't like this idea as the test should be decoupled. Therefore two PRs;
- adding the test cartridge collection JSON
- Updating travis file to test collection
I'm not really keen on two PRs really as it means we can't update the test data and tests at the same time and adds additional overhead.
Whats your opinion?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cartridge collection load test to travis as it is important to confirm that we can actually load a cartridge using the CLI. A number of delivery patterns may depend on the CLI for automating provisioning.
Notes: I'll update the cartridge collection URL to this repo once the travis checks have run (travis will fail until the dependent PRs are merged)
Dependent on:
Signed-off-by: Northard, Robert A robert.a.northard@accenture.com