Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rocky Linux 8.7 Build Instructions #384

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

beatreichenbach
Copy link

@beatreichenbach beatreichenbach commented Feb 2, 2024

Linked issues

Related discussions

#346
#352
#90
#382

Summarize your change.

Adding documentation for Rocky Linux 8.7 Build.

Describe the reason for the change.

The existing documentation was lacking.

Describe what you have tested and on which operating system.

Rocky Linux 8.7

Add a list of changes, and note any that might need special attention during the review.

If possible, provide screenshots.

Copy link

linux-foundation-easycla bot commented Feb 2, 2024

CLA Missing ID CLA Not Signed

Copy link
Contributor

@geffrak geffrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Thanks for your contribution. I somehow missed it.

@@ -1,97 +1,64 @@
#!/bin/tcsh -f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the other wrappers too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for other wrappers? Is there any system that doesn't use sh out of the box?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean rvio.wrapper, py-interp.wrapper, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geffrak I think I found all the tcsh scripts. Lmk what you think!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geffrak thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants