cleanup: change raw cerr stream output to print #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small piece of the ongoing switch to std::format/print style text output. This part is for error and debugging output when reading/writing exr images. I also switched conditional compilation to the DBG macro idiom that I've used elsewhere, where it takes a combination of DEBUG compile and setting of environment variable OIIO_DEBUG_OPENEXR to trigger the printf style debugging (the first use case of this was in our color management code, which I also modify slightly here to conform). Also opportunistically simplify gcd delcaration now that we're C++17 minimum. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
No objections for 2 weeks -> merging |
lgritz
merged commit 41c8949
into
AcademySoftwareFoundation:master
23 of 24 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 20, 2024
…ation#4258) A small piece of the ongoing switch to std::format/print style text output. This part is for error and debugging output when reading/writing exr images. I also switched conditional compilation to the DBG macro idiom that I've used elsewhere, where it takes a combination of DEBUG compile and setting of environment variable OIIO_DEBUG_OPENEXR to trigger the printf style debugging (the first use case of this was in our color management code, which I also modify slightly here to conform). Also opportunistically simplify gcd declaration now that we're C++17 minimum. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
May 21, 2024
…ation#4258) A small piece of the ongoing switch to std::format/print style text output. This part is for error and debugging output when reading/writing exr images. I also switched conditional compilation to the DBG macro idiom that I've used elsewhere, where it takes a combination of DEBUG compile and setting of environment variable OIIO_DEBUG_OPENEXR to trigger the printf style debugging (the first use case of this was in our color management code, which I also modify slightly here to conform). Also opportunistically simplify gcd declaration now that we're C++17 minimum. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small piece of the ongoing switch to std::format/print style text output. This part is for error and debugging output when reading/writing exr images.
I also switched conditional compilation to the DBG macro idiom that I've used elsewhere, where it takes a combination of DEBUG compile and setting of environment variable OIIO_DEBUG_OPENEXR to trigger the printf style debugging (the first use case of this was in our color management code, which I also modify slightly here to conform).
Also opportunistically simplify gcd declaration now that we're C++17 minimum.