New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(windows): Do not try to build minizip before zlib. #1965
base: main
Are you sure you want to change the base?
Conversation
8d741d8
to
908dd19
Compare
Signed-off-by: Sławomir Śpiewak <sosw.slawomir.spiewak@gmail.com>
@SlawekNowy , thanks for the PR. Would you please provide more detail about what scenarios require this fix? In other words, most Windows builds succeed already without this, so it must be something more specific about the way you are building. |
This is the local windows build. Fetched the repository and built it using Visual Studio generator. Both minizip and zlib are managed by opencolorio. Visual studio 2022 Community x64. |
Oh. I forgot to mention I run Also it seems that did not fix my problems? |
The build is done using |
I'll admit this is not standard setup, but this repo's CMakeLists does fetch deps... |
From parent project's discord:
|
Hi Slawek, I encountered the same problem on Windows. It seems that minizip-ng sometimes builds before zlib, which causes a build error, because minizip-ng depends on zlib. I was able to fix it locally by adding a dependency on Zlib in the i.e.
Could you try this and see if it fixes your build? |
No description provided.