Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking when building fully shared with the dependencies also build as shared libraries #1958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

irieger
Copy link

@irieger irieger commented Mar 19, 2024

I'd suggest to fix the linking to ensure OpenColorIO can be build with its own requirements build as shared libraries. Currently it will throw linker errors when linking all the included CLI tools.

For more details, also see: conan-io/conan-center-index#23112

Up to now the conan recipe didn't run with dynamic linking as there was a blocker in the configuration to link minizip-ng dynamically. When I tried to fix it locally, I came up with this change. Otherwise it can also be done by fixing the linking of all the tools to include the requirements manually.

Copy link

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant