New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some compatibility issues for building on some platforms #1930
base: main
Are you sure you want to change the base?
Fix some compatibility issues for building on some platforms #1930
Conversation
|
Please feel free to use my suggestions. To my understanding I'd need to publish my postal address (that is what I assumed is meant by "Mailing Address" in the CLA form) to sign the CLA which I currently don't see doing as this seems shady to me. |
… conan Signed-off-by: Ingmar Rieger <git@irieger.net>
9ee6a40
to
00ed94f
Compare
Hi! All Linux Foundation CLAs require some sort of physical address, it's pretty standard practice in open source. When you contribute under a company CLA, you get to use your company's address instead, so it seems less "personal". I understand being uncomfortable with it - if you would like to read more about the CLA & LF's data protection / security standards (which are pretty good) here's the link: https://www.linuxfoundation.org/legal/privacy-policy |
Regarding std::strlen, I see a number of other places using just strlen, you didn't encounter issues with those? |
That was the only issue when packaging for conan at least. |
Thanks for the hint. However just having a quick scan through this already makes my feeling about the linux foundation worse than it was before. Openly using tracking is just shit, especially for an organization that I thought was proposing Open Source philosophies. There is no technical need for tracking users. If this was a company contribution I wouldn't care much about the address topic but as this is free time work I'm happy for the team to copy my suggestions but I'm not willing to dive into such a lengthy legal document in a non-native language that doesn't provide me anything but making me more angry about an organization that I thought works for open things. (Part of the open source philosophy for me is to give the users the freedom of their data!) |
@irieger totally respect your position. Thank you for the pointers regardless! |
There is a file that was added/changed to include pystring which is a regression to the changes in #1901 which fixed problems with the include directory of pystring by removing the
pystring/
directory prefix from the include path.I also suggest adding std for strlen which also otherwise fails to build in some compiler/OS constellations, at least when building for conan.