Hocon config companions #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddworak
reviewed
Apr 11, 2024
|
|
||
| /** | ||
| * Use this type in data deserialized from HOCON to in order to read size in bytes represented with | ||
| * [[https://github.com/lightbend/config/blob/master/HOCON.md#size-in-bytes-format HOCON's nice representation]]. |
There was a problem hiding this comment.
Based on this source, there are a lot more strings supported in HOCON.
|
|
||
| import scala.concurrent.duration.* | ||
|
|
||
| trait CommonsHoconCodecs { |
There was a problem hiding this comment.
nit, naming: we already have CborOptimizedCodecs and BsonGenCodecs. Maybe we should try to stay consistent with one of those in naming (probably the latter).
Comment on lines
+15
to
+20
| input.readCustom(ConfigValueMarker).map { | ||
| case obj: ConfigObject => obj.toConfig | ||
| case v => throw new ReadFailure(s"expected a config OBJECT, got ${v.valueType}") | ||
| }.getOrElse { | ||
| ConfigFactory.parseString(input.readSimple().readString()) | ||
| }, |
There was a problem hiding this comment.
nit: I could be convinced this is one of the rare instances where .fold looks cleaner
Comment on lines
+37
to
+41
| implicit final val classKeyCodec: GenKeyCodec[Class[?]] = | ||
| GenKeyCodec.create(Class.forName, _.getName) | ||
|
|
||
| implicit final val classCodec: GenCodec[Class[?]] = | ||
| GenCodec.nullableString(Class.forName, _.getName) |
There was a problem hiding this comment.
What would be the use case for those in config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add base companions for classes representing HOCON config