Hierarchy CreatePack #816
Draft
Hierarchy CreatePack #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doomsdayrs
force-pushed
the
hierarchy-createpack
branch
from
bf31b87
to
dfa90d8
Compare
Doomsdayrs
force-pushed
the
hierarchy-createpack
branch
from
5a61451
to
de33a56
Compare
RyanTheAllmighty
force-pushed
the
master
branch
4 times, most recently
from
63bf590
to
b4b8d95
Compare
Doomsdayrs
force-pushed
the
hierarchy-createpack
branch
from
a60bf91
to
73628c3
Compare
RyanTheAllmighty
force-pushed
the
master
branch
5 times, most recently
from
132f3b9
to
6d887e5
Compare
* chore: migrate to the new Gradle version catalogs for the libraries and plugins. * docs: add the change of migrating to Gradle version catalogs in CHANGELOG.md file --------- Co-authored-by: Ryan Dowling <ryan@ryandowling.me>
* chore: update Gradle wrapper version from 8.2 to 8.7 * docs: add gradle wrapper version update in the Misc section in CHANGELOG.md file --------- Co-authored-by: Ryan Dowling <ryan@ryandowling.me>
…r#898) * refactor(gradle): Migrate from Gradle groovy to Gradle KTS * chore: remove duplicated implementation(libs.log4j.api) * docs: update CHANGELOG.md file to mention the new change * fix: allow using forked gettext in the plugins block and use it in type-safe * chore: remove duplicated includeGroup('com.github.RyanTheAllmighty.gettext') * chore: remove macos-app-bundle version plugin from libs.versions.toml for the original repository to use the forked one * chore: remove duplicated macos-app-bundle to use only the forked one, clean up the repositories block. * chore: update a comment * chore: configure the plugins directly for the plugins that support the plugins block * fix: checkLicenses task wasn't working properly because of '' in the double quotes, work properly now * fix: set the year property correctly * revert: use gettext library from the forked repository just like before * refactor: configure plugins and gradle tasks using better syntax * fix: workaround to remove checkLicenses task * docs: remove the issue link Co-authored-by: Ryan Dowling <ryan@ryandowling.me> * chore: remove duplicated finalizedBy(copyArtifacts) task * refactor: use the tasks {} block --------- Co-authored-by: Ryan Dowling <ryan@ryandowling.me>
…after launching the game (ATLauncher#893) * Add default minecraft server port in the Constants * feat: allow the player to join a minecraft server after launching the game * chore: Rename property joinInitialServerAddress to initialJoinServerAddress * Update CHANGELOG.md to add the new feature * docs: Update a comment * Update CHANGELOG.md Co-authored-by: Ryan Dowling <ryan@ryandowling.me> * Update src/main/java/com/atlauncher/gui/dialogs/instancesettings/GeneralInstanceSettingsTab.java Co-authored-by: Ryan Dowling <ryan@ryandowling.me> * feat: add server address input validation by ValidationUtils class * refactor: Use quickPlay data class for holding the initial join server address field for single player and realms support later * feat: add getSinglePlayerWorldNamesFromFilesystem in the Instance class to load the single player save names * feat(quickplay): add support for quick play for realm and single player, refactor some of the code to add this feature * docs: Update the description to fit the new changes in CHANGELOG.md file * fix: update outdated naming for the realm quick play feature * refactor(quickplay): use public data class properties for the QuickPlay * chore(quickplay): remove todo support for joining single, realm worlds for versions older than 23w14a * refactor(quickplay): move the check quick multiplayer supported into the Instance class * refactor(quickplay): only one method for checking is quick play supported, remove some argument rule value duplications * revert: restore the imports to the previous state. * feature(quickplay): only add the supported quick play options on older versions of Minecraft --------- Co-authored-by: Ryan Dowling <ryan@ryandowling.me>
* misc: Implement HierarchyPanel in ServersTab * fix: Scroll state not being held properly
* Establish RXJava in NewsTab/ViewModel * misc: Move NewsManager.getNewsHTML to NewsViewModel These are UI only code that is unspecific to the NewsManager * misc: Refactor News stack There are currently two ways to load news. From JSON and from GraphQL Currently, Data.NEWS only handles json news, not graphql news. This commit changes that. InstanceManager now handles all news and their processes under AbstractNews. This liberates NewsTab from being the middleman for loading news. * misc: Decouple NewsTab from Launcher * misc: Unify news loading into a single function
* Add basis of the About Tab * Fix license * Added AboutTab basic north info Copy button seems to not work? * Add documentation on what AboutTab is * Ensure copy and paste of information is legible * Add basic authors list * Separate AboutTab business logic via view model * Improve UI design The Info and authors bar are better spread out now. * Fix licenses * Add flatpak note to about info * Update authors * Fix directory structure * Clean up AboutTab style * Row of authors to list of authors + images * Use grid layout for Authors instead * Update CHANGELOG.md * Add some logos * AboutTab: Use BoxLayout instead of BorderLayout * AboutTab: Let view model handle imageURL logic * Further improvements * Update LICENSEHEADER * Add license to AboutTab * Revert "Update LICENSEHEADER" This reverts commit 8fddf7c. * Some minor edit * Improvements * Add Nonnull annotations to LauncherLibrary * Remove new line from license in AboutTab * fix: Add LAUNCHER_ABOUT_TAB to UIConstants * misc: Add empty constructor for HierarchyPanel Useful for when you do not want to set a LayoutManager so early. * misc: Make AboutTab inherit HierarchyPanel Default launcher memory usage is around 30Mb~. Opening the about tab jumps memory to 100+Mb. Closing the about tab drops memory back to 30Mb~. * misc: Disable Acknowledgements & Libraries in AboutTab So we can ship this UI earlier. * misc: Add license to LauncherLibrary
317fe4c improperly used GetText in GeneralInstanceSettingsTab, leading to a crash. This was solved by instead translating the source text in the enum definition instead of the SettingsTab definition.
… GraphQL (ATLauncher#903) * feat: read LICENSE from file for about page and get contributors from GraphQL * chore: update changelog and version * fix: remove unused and better license with fixed scrollpane * Add async call function to GraphqlClient * Make IAboutTabViewModel.getContributors async Decouples UI rendering from IO tasks. --------- Co-authored-by: doomsdayrs <doomsdayrs@gmail.com>
* Deprecate MojangAccount It is gone. * Remove MojangAccount from Instance.java * Add deprecation flags throughout codebase * Remove MojangAccount functionality from AccountsTabg * Remove Authentication.java, LoginResponse.java * Drop more references to MojangAccount from AccountManager.java * Remove `userdata.json` conversion code. It relied on MojangAccount, todaloo! * Delete MojangAccount.java Closes ATLauncher#906 * Remove Mojang AuthLib - Replaces UUIDTypeAdapter with java internal UUID - Replace org.apache.commons.io.IOUtils with org.apache.commons.compress.utils.IOUtils * Replace AbstractAccount from AccountManager and dependents * Handle UUID spec shenanigans
* chore: remove useless gradle summaries * chore: update versions of Java tested in GitHub workflows
* chore: update dependencies * fix: downgrade commonmark to fix build issues * fix: remove old usage of JUnit 4 classes
Doomsdayrs
force-pushed
the
hierarchy-createpack
branch
4 times, most recently
from
e376ba4
to
28891e0
Compare
Doomsdayrs
force-pushed
the
hierarchy-createpack
branch
from
28891e0
to
20fc56a
Compare
HierarchyPanel handles that already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Implement Hierarchy CreatePack
Testing
It seems the generally, the fields change on time. There seems to be some delay in some fields resuming their previous states.
ISSUE It seems that the input field is not stable. I will have to investigate to find the instability source.
Related Issues
Requires #625