Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: radar_freq param in hydroclass_semisupervised #1573

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

RBhupi
Copy link
Contributor

@RBhupi RBhupi commented Apr 30, 2024

  • Documentation reflects changes
  1. Added radar_freq option when frequency information is missing from the radar object.
  2. Now always print warning showing frequency used by the function.
  3. Added docstring for thechange.
  4. Modified the old notes section to include radar_freq.

@RBhupi RBhupi requested a review from zssherman as a code owner April 30, 2024 14:44
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RBhupi - can you please add a test/example here?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RBhupi - can you please convert your example to a .py? It should look similar to other examples (ex. https://github.com/ARM-DOE/pyart/blob/main/examples/retrieve/plot_column_subset.py). This will ensure it renders correctly on the example gallery!

Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hydrometeor_class_x-band_example.py
rename file to:
plot_hydrometeor_class_x_band.py

Needed so it is generated correctly.

@RBhupi
Copy link
Contributor Author

RBhupi commented May 1, 2024

This is failing because of the missing file. I want to use this file in my example which I can take from the ARM servers.

WARNING:
../../examples/retrieve/plot_hydrometeor_class_x_band.py unexpectedly failed to execute correctly:

Traceback (most recent call last):
  File "/home/runner/work/pyart/pyart/examples/retrieve/plot_hydrometeor_class_x_band.py", line 29, in <module>
    radar = pyart.io.read(files[0])
                          ~~~~~^^^
IndexError: list index out of range

@zssherman
Copy link
Collaborator

@RBhupi If you want to pull the file and run that, you can do a PR adding the file to https://github.com/openradar/open-radar-data

then once the file has been added to the data directory, run python make_registry.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants