ADD: Transparency options for geotiff writer #1496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qubitqualia Thanks for the PR! Looks reasonable to me! Think just some PEP8 fixes are needed for the nonewline etc |
|
Should be good now. This is my first pull request so thank you for your patience! |
|
No worries! Rerunning the tests now |
|
Looks like a few more PEP8 changes. |
|
@qubitqualia I left a few more comments, and quick question, are we setting the default to transparent? Or are we setting it to normal prior to this PR and if a user wants to they can set it to transparent, I saw the transparent parameter set to true and wanted to make sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options to the geotiff writer that allow RGB images to be created with a transparent background. An opacity setting was also added to control the overall transparency of the output image.