Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8838 _Factors table fixes #8881

Merged
merged 5 commits into from May 1, 2024
Merged

Conversation

par456
Copy link
Collaborator

@par456 par456 commented Apr 30, 2024

Resolves #8838

There were two things happening here.

One was that the _Factors table was not being cleared at the start of a run, so running a simulation multiple times meant the table would just keep growing each time. That is despite having comments saying it should be cleared, so I added it to the list with _Messages and _IntialConditions to be cleared at the start of a run.

Then for the repeated lines, it turns out the factors were written for each report instead of for each simulation. So if a simulation had 4 reports, it would write the factors in 4 times to the table. To fix this I moved the code from Report over to simulation, however that may not be the most appropriate place for it, so would like some feedback.

@par456 par456 requested a review from hol353 May 1, 2024 04:14
@hol353 hol353 merged commit 6d5d509 into APSIMInitiative:master May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_Factors table is repeating rows
2 participants