Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lincoln high yield wheat experiments to test set #8821

Merged
merged 36 commits into from Apr 16, 2024

Conversation

HamishBrownPFR
Copy link
Contributor

working on #8820

@par456
Copy link
Collaborator

par456 commented Apr 12, 2024

Just noticed that the data in the GrainSize column that you renamed was also in the wrong units. PO stats shows it across a few of the tables.

@HamishBrownPFR
Copy link
Contributor Author

resolves #8820. @hol353 @par456 @ric394 please review and merge if happy. I have added two test sets to the wheat validation, removed superfluous columns from the observed files (i.e things that can't be compared with model outputs) and fixed a variable name (Wheat.Grain.GrainSize -> Wheat.Grain.Size.
Most changes to the stats are positive or trival negatives. The negative changes that are not trival are due to the inclusion of the Wheat.Grain.Size data in PO stats and in LAI where the then data sets added are highlighting some challenges to the model. These issues are being worked on in a current project

@hol353
Copy link
Contributor

hol353 commented Apr 14, 2024

@HamishBrownPFR This looks ok but can you get this branch up to date please to be sure.

@HamishBrownPFR
Copy link
Contributor Author

@hol353 sorry, I thought it was up to date. should be now.

@hut104
Copy link
Contributor

hut104 commented Apr 15, 2024

@HamishBrownPFR Do you know why the total number of Haun stage data in ObsDaily stats has decreased?
I understand the values of N increasing for other outputs, but not a decrease?

@HamishBrownPFR
Copy link
Contributor Author

@hut104 good question. It should have gone up. I will investigate

@HamishBrownPFR
Copy link
Contributor Author

@hol353 @hut104 The SimulationName column in LaTrobeCE_OBS had an equation in some rows that was referencing some of the superfluous columns I deleted. I have instated the correct simulation names without equations.

@HamishBrownPFR
Copy link
Contributor Author

@hol353 this should be good to merge now

@hol353 hol353 merged commit e2fa03c into APSIMInitiative:master Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants