Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed data to protocol #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter-devoil
Copy link

resolves #8771

@hol430
Copy link
Collaborator

hol430 commented Mar 21, 2024

For some reason, I seem to have write access to this repository (or perhaps there are no branch protection rules in place?).

Nice - although midly alarming - to see that people are still using this. Did anyone end up finding a way to guarantee that simulations correctly reset/reinitialise their state at end-of-simulation? Without such a guarantee, this method of running simulations was always rather academic, and their outputs should be treated with a large grain of salt (even moreso than usual!).

@hol353
Copy link

hol353 commented Mar 21, 2024

There aren't any branch protection rules in place, nor any auto testing.

Did anyone end up finding a way to guarantee that simulations correctly reset/reinitialise their state at end-of-simulation?

No, unfortunately.

@d11638104
Copy link

For some reason, I seem to have write access to this repository (or perhaps there are no branch protection rules in place?).

Nice - although midly alarming - to see that people are still using this. Did anyone end up finding a way to guarantee that simulations correctly reset/reinitialise their state at end-of-simulation? Without such a guarantee, this method of running simulations was always rather academic, and their outputs should be treated with a large grain of salt (even moreso than usual!).

Your insight has been truly inspiring. However, if I were to opt out of using it, are there alternative options available? Your guidance would be greatly appreciated.

Copy link

@d11638104 d11638104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your gracious response. I conducted a simple test, and it appears to have produced the desired outcome. I also noticed that the earlier client code did indeed lack the "type" field. Once again, thank you for your amendments. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants