Port Add height of cluster with the most points method #323 to master #329
Conversation
|
Hey, some changes have been merged, or will be merged, can you update the MR? |
|
@maximilianwulf |
kosuke55
force-pushed
the
feature/port_height_of_cluster_with_the_most_points
branch
from
5e41cda
to
0cc1b53
Compare
|
Thank you, will import the MR. |
|
One unit test was failing due to the API change, I fixed it internally. Could you provide a second MR with a unit test of this code change? |
|
@maximilianwulf |
| @@ -47,6 +47,11 @@ class PclLoaderParameters { | |||
| double resolution_ = 0.1; | |||
| unsigned int minCloudPointsPerCell_ = 2; | |||
There was a problem hiding this comment.
useMaxHeightAsCellElevation_ in ClustExtractionParameters can be deleted, right?
| @@ -47,6 +47,11 @@ class PclLoaderParameters { | |||
| double resolution_ = 0.1; | |||
| unsigned int minCloudPointsPerCell_ = 2; | |||
| unsigned int maxCloudPointsPerCell_ = 100000; | |||
| // 0: Smallest value among the average values of each cluster | |||
| // 1: Mean value of the cluster with the most points | |||
There was a problem hiding this comment.
What happend to type = 2?
There was a problem hiding this comment.
Oh i just copy ros2 version. Fixed in 1f1ab69
|
@maximilianwulf |
|
ping @maximilianwulf |
1 similar comment
|
ping @maximilianwulf |
|
friendly ping @maximilianwulf |
|
kindly ping @maximilianwulf |
I ported #323 to master. (ros2 -> ros1)
height_threshis a parameter to reduce the influence of point clouds that exist in high locations such as ceilings.0: Smallest value among the average values of each cluster (current method)
1: Largest value among the average values of each cluster (current method which is implemeted only for ros1)
2: Mean value of the cluster with the most (new method)
