update unit test #275
Open
update unit test #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update unit test with PositiveClosestPositionInMap and NegativeClosestPositionInMap.
|
Thank you, the unit tests fail, right? |
You're welcome! Indeed the unit test failed because of the bug where the return negative value (length of the grid map) is invalid when getIndex() function is called. |
hogabrie
added a commit
that referenced
this pull request
Jan 15, 2021
GitOrigin-RevId: 2ccf404f896965a2d512814befae59fb1f9b0d45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update unit test with PositiveClosestPositionInMap and NegativeClosestPositionInMap.
This is regarding issue #272 where I was requested to submit a unit test.
Hope this helps to discover the bug. Thank you.