Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: specify version.h as a dependency of all object files #590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Makefile: specify version.h as a dependency of all object files #590

wants to merge 1 commit into from

Commits on Aug 20, 2023

  1. Makefile: specify version.h as a dependency of all object files 

    Otherwise parallel builds fail occasionally as:

    $ make --shuffle -j
    ...
    g++ -c   -O3 -D__STDC_FORMAT_MACROS   argStruct.cpp
    g++ -c   -O3 -D__STDC_FORMAT_MACROS   ancestral_likes.cpp
    gcc -c   -O3 -D__STDC_FORMAT_MACROS   fet.c
    g++ -c   -O3 -D__STDC_FORMAT_MACROS   abcGL.cpp
    g++ -c   -O3 -D__STDC_FORMAT_MACROS   pop1_read.cpp
    g++ -c   -O3 -D__STDC_FORMAT_MACROS   angsd.cpp
    g++ -c   -O3 -D__STDC_FORMAT_MACROS   abcHWE_F.cpp
    gcc -c   -O3 -D__STDC_FORMAT_MACROS   kprobaln.c
    g++ -c   -O3 -D__STDC_FORMAT_MACROS   mpileup.cpp
    argStruct.cpp:3:10: fatal error: version.h: No such file or directory
        3 | #include "version.h"
          |          ^~~~~~~~~~~
    compilation terminated.
    angsd.cpp:11:10: fatal error: version.h: No such file or directory
       11 | #include "version.h"
          |          ^~~~~~~~~~~

Before the change it was enough to try to build `angsd` with 1-2
`make --shuffle` runs to get the failure. After the change the build
survives 20 rebuilds.
    @trofi
    trofi committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    89fd1d8 View commit details
    Browse the repository at this point in the history