Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid symbol clashes in plot_expressions #2440

Merged
merged 1 commit into from
May 14, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 13, 2024

Ignore sympy constants when sympifying expression strings to avoid clashes with sympy.*.

Ignore sympy constants when sympifying expression strings to avoid
clashes with sympy.*.
@dweindl dweindl requested a review from a team as a code owner May 13, 2024 09:29
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.20%. Comparing base (4eb4bbd) to head (508dc1f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2440      +/-   ##
===========================================
- Coverage    77.64%   76.20%   -1.44%     
===========================================
  Files          324      319       -5     
  Lines        20928    20767     -161     
  Branches      1464     1464              
===========================================
- Hits         16249    15826     -423     
- Misses        4676     4937     +261     
- Partials         3        4       +1     
Flag Coverage Δ
cpp 73.40% <100.00%> (-0.02%) ⬇️
cpp_python 34.09% <0.00%> (ø)
petab ?
python 72.17% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/numpy.py 87.61% <100.00%> (ø)

... and 21 files with indirect coverage changes

@dweindl dweindl merged commit 0c00046 into AMICI-dev:develop May 14, 2024
16 of 20 checks passed
@dweindl dweindl deleted the plotting_clash branch May 14, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants