New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subset dev #14
base: master
Are you sure you want to change the base?
Subset dev #14
Changes from all commits
f29eb3b
d87fd23
ae6a2c4
6cceb7e
1028dcf
20983fd
8c65a27
2e52567
2c51078
1726bd8
87d299a
34f6a49
07741dc
e36021c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,4 @@ pandas==1.5.* | |
scipy==1.10.* | ||
axographio==0.3.2 | ||
pyobjc-framework-Cocoa==6.2.2;sys_platform=='Darwin' | ||
cython<=0.29 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
from scipy import io | ||
import os | ||
import json | ||
import pickle | ||
from ..utils.tools import parse_filename | ||
|
||
|
||
|
||
def save_metadata(data, filename): | ||
|
@@ -96,8 +99,10 @@ def save_data(data, filename="", filetype="mat", save_piezo=True, save_command=T | |
save_piezo=save_piezo, | ||
save_command=save_command, | ||
) | ||
|
||
# elif filetype == "pkl": | ||
# return_status = save_pickle(data=data, filepath=filepath) | ||
|
||
else: | ||
print('Can only save as ".mat"!') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or as ".pkl" now :). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh wait, actually no. The save_pickle function this is referring to is still commented out. Nevermind! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed it again |
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same as
if self.idealization(episode.n_episode):
so you don't have to useis not None
at the end. Python treatsNone
as well as empty list ([]
) and empty string (''
) asFalse
in this context.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Maybe I put an explanatory comment.