Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake build #17

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

cmake build #17

wants to merge 9 commits into from

Conversation

gf712
Copy link

@gf712 gf712 commented Feb 9, 2018

I wrote CMakeList.txt files that use cmake to generate Makefiles.
This makes it easier for any user to write to install and has the same behaviour as the current Makefiles. The main advantage is that it looks for dependencies and adds the corresponding libraries.

So to build bioplib, it would be something like this:

mkdir build
cd build/
cmake .. <- this generates the makefiles, and any path variable can be set here, like Makefiles just add -DVariableName, i.e. -DDEST='path/to/folder/' to set install directory
make
make install
make test <- run tests directly from project build directory

Note that all other original make recipies are included in the CMakeList.txt, e.g. make shared.
The root CMakeList.txt file also calls another CMakeList.txt file in the test/ directory which builds the test files.
(I also moved the test directory to the project directory to make it easier to find..)

I hope this is helpful, as I found it really convenient to install bioplib this way on my machine and I am working on something similar with bioptools!

Gil added 9 commits February 9, 2018 16:36
also changed the tests:
- tmp directory might only be accessible with sudo rights in some systems causing tests to fail
- it does not make sense to check if boolean is less than 0 -> ABS(pdb->formal_charge <= 8)
- this is probably meant to be ABS(pdb->formal_charge) <= 8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant