Add PushAmount trait to track the reason behind a push
#2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channel initiator traditionnally pays the commit tx fees, but we may want to override that when providing services to wallet users. We thus split the current `isInitiator` flag into two flags: - `isChannelOpener` - `payCommitTxFees` We always set `payCommitTxFees` to the same value as `isChannelOpener`. Custom feature bits may override that behavior if necessary. Note that backwards compatibity is preserved since our previous `bool8` codec encodes `true` as `0xff` and `false` as `0x00`.
We have the ability to push some funds to our peer when opening a channel or splicing. This is generally used between LSPs and wallets to pay fees for on-the-fly funding, but can also be used for many other reasons. We introduce a dedicated trait for that field instead of using a plain amount: that allows carrying more data than just an amount, and provides better insights of why some funds were pushed. This is purely a refactoring at that point, without any logical changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the ability to push some funds to our peer when opening a channel or splicing. This is generally used between LSPs and wallets to pay fees for on-the-fly funding, but can also be used for many other reasons.
We introduce a dedicated trait for that field instead of using a plain amount: that allows carrying more data than just an amount, and provides better insights of why some funds were pushed.
This is purely a refactoring at that point, without any logical changes.
NB: this builds on top of #2845