Update trampoline to use official spec values #2819
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
+ Coverage 85.86% 85.96% +0.09%
==========================================
Files 216 217 +1
Lines 18228 18256 +28
Branches 772 778 +6
==========================================
+ Hits 15652 15694 +42
+ Misses 2576 2562 -14
|
Use the feature bit and tlvs defined in the official spec PR (lightning/bolts#836). Add support for the spec test vector.
t-bast
force-pushed
the
trampoline-spec-version
branch
from
ee178c7
to
bd76a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the feature bit and tlvs defined in the official spec PR (lightning/bolts#836). Add support for the spec test vector.
This PR is incomplete: we also need to actually use the official feature bit (in conjunction with the experimental one) and integrate the onion errors defined by lightning/bolts#836. We also need to think about backwards-compatibility when relaying trampoline payments to older Phoenix nodes (we should write the trampoline TLV with the old tag).