Drop compat code for java 8 #2155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
previously approved these changes
Jan 27, 2022
|
There is actually a catch, as c848cfe shows. |
|
I'm interested in your opinion on |
This is most consistent with Java API, it adds `obj.getClass.getPrettySimpleName` to the existing `obj.getClass.get*Name`. Instead we could go with a nicer `obj.prettyClassName`.
pm47
force-pushed
the
drop-java8-compat
branch
from
de8bc92
to
e43bcdd
Compare
|
Since this isn't trivial after all, I think it should wait for after the release. |
t-bast
approved these changes
Feb 2, 2022
| Foo.Bar -> "Bar", | ||
| Foo.Baz(42) -> "Baz" | ||
| ).foreach { case (o, ref) => assert(o.getClass.getPrettySimpleName == ref) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a long time and officially supported version is Java 11.
This can wait after the upcoming release though.